Re: [Libreoffice] [REVIEW] Fix for fdo#37520

On Tue, May 24, 2011 at 3:03 PM, Kohei Yoshida <kohei.yoshida@gmail.com> wrote:
> The attached patch fixes the crasher reported in
>
> https://bugs.freedesktop.org/show_bug.cgi?id=37520
>
> The crash occurs in ScRangeList::Join() where the array size is cached
> prior to the for loop, but array may shrink during the loop, in which
> case an out-of-bound array access may occur which in turn results in a
> crash.  I'm actually surprised that this didn't cause a crash on
> Linux.
>
> Anyhow, the solution is to always dynamically check the size of the
> array via size() method in each iteration, instead of caching it for
> all iterations.
>
> Review appreciated.  I'd like this to go into the -3-4-0 branch.  So I
> need three sign-off's.

+1

Norbert