Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello Katarina,

the idea is good, but I think we should move this code to
ScDocument::GetFilterDBAtTable because I'm not quite sure if there are not
some cases where there is a sheet local db data but no dbcollection. I
personally would prefer that but I'm fine with this patch too.

Sol you've my sign of.

Regards, Markus

 <http://opengrok.libreoffice.org/s?defs=ScDocument&project=calc>
 <http://opengrok.libreoffice.org/s?refs=GetFilterDBAtTable&project=calc>


2011/5/24 Katarina Machalkova <kmachalkova@suse.cz>

Ladies & gentlemen,

attached is the patch with (hopefully the final) fix for $subject. I'd like
to
push it to 3-4 and considering the fact that some data loss is involved,
prolly also to 3-4-0 although I'm not entirely positive about that.

The orig. patch from IBM Symphony folks took just some scenarios into
account
and happily kept deleting cell data in drag-fill operation in all other
cases
(as described here: https://bugs.freedesktop.org/show_bug.cgi?id=35345#c10
)

Now we're trying to look also for anonymous DB data in the current sheet
and
check those for the presence of autofilter or query params.

Please review & comment. /me doesn't know this particular pieces of code so
well.

frozenB.
--
 \\\\\              Katarina Machalkova
 \\\\\\\__o          LibO developer
__\\\\\\\'/_          & hedgehog painter


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.