[Libreoffice] Need help with the Bug 33092 – Autocomplete display double character for this word [CTL / Thai]

Hi,

We've been trying to fix this bug https://bugs.freedesktop.org/show_bug.cgi?id=33092

However, we don't know whether the approach that we've tried is the right thing, so can you please review the following idea.

Step to reproduced the bug:

1.Use Thai locale, open a blank Writer document
2.Switch keyboard to Thai.
3.Type text “มิถุ” by press “,b5”.
4.The function autocomplete will display the full word "มิถุนายน" (June in Thai)
5. Press enter to accept the suggestion, and another enter for readability
6. Repeat the step 3-5 once

Expect result:
There should be two lines of  “มิถุนายน”.

Real result:
There are two lines of “มิถุนายน” but the first one has a doubled/overlapped cluster. See below.


It is strange that the second (and later) autocompletion of the same word doesn't trigger the same bug.

Look at the content.xml

<style:style style:name="T1" style:family="text">
   <style:text-properties style:language-complex="th"
style:country-complex="TH"/>
</style:style>
....snip.....
<text:p text:style-name="P1">มิถ<text:span text:style-name="T1">ุนายน</text:span></text:p>
<text:p text:style-name="P1"><text:span text:style-name="T1">มิถุนายน</text:span></text:p>

There is an auto-style T1 which switch the locale to th. In the 2nd paragraph, the auto-style is placed around the autocompleted word. However, in the first line, the auto-style is placed just before the suggestion. Moreover, for the word มิถุนายน, the auto-style happen to be placed inside a cluster ถ+ ุ , which result in ugly display of the cluster. Because the display function still cannot handle this case well.

We've tried removing the whole auto-style T1 from the ODT and everything is fine again. Then we couldn't find a reason why LO need to put the auto-style while autocomplete in the first place. Because the user is typing in a locale, then autocompletion of the same locale is fired. So the whole text must be in the same locale. Why put and auto-style to switch to the same locale?

So we've try an experimental patch (https://bugs.freedesktop.org/attachment.cgi?id=45511 ) that get rid of the auto-style when autocomplete altogether. We've tried it with no side-effect as of now. But I don't know whether actually the auto-style is needed for a reason we don't understand.

Any idea?

Thanks,
Samphan.

--
_/|\_ Samphan Raruenrom.  Osdev - Open Source Development Co., Ltd.
สัมพันธ์ ระรื่นรมย์.  โอเอสเด็บ - บริษัท โอเพนซอร์สดิเวลอปเมนต์ จำกัด
tel: +66 2 269 9889  web: osdev.co.th
twitter: @osdev  facebook: facebook.com/osdev