[Libreoffice] [REVIEWED - 1 more needed] Re: [Patch] Hover over icons produces the wrong behavior

Jan Holesovsky <kendy -AT- suse.cz>
Fri, 20 May 2011 11:20:55 +0200

Hi Lucas,

On 2011-05-19 at 21:53 +0200, xapantu wrote:

sal_uInt16 bHighlight = sal_False


I think this should become sal_uInt16 bHighlight = 0, or even
nHighlight; the 'b' prefix suggests it is a bool [and it is not ;-)]

Tor - when you are pushing this, can you please update it?

[Actually - this is a 2nd sign-off ;-)]

Regards,
Kendy

Context

[Libreoffice] [Patch] Hover over icons produces the wrong behavior · xapantu
- Re: [Libreoffice] [Patch] Hover over icons produces the wrong behavior · Tor Lillqvist
- Re: [Libreoffice] [Patch] [PUSHED] [REVIEW REQUEST] Hover over icons produces the wrong behavior · Tor Lillqvist
  - Re: [Libreoffice] [Patch] [PUSHED] [REVIEW REQUEST] Hover over icons produces the wrong behavior · Michael Meeks
    - Re: [Libreoffice] [Patch] Hover over icons produces the wrong behavior · Tor Lillqvist
- [Libreoffice] [REVIEWED - 1 more needed] Re: [Patch] Hover over icons produces the wrong behavior · Jan Holesovsky
  - [Libreoffice] [REVIEWED - 1 more needed] Re: [Patch] Hover over icons produces the wrong behavior · Tor Lillqvist
    - [Libreoffice] [PUSHED] Re: [REVIEWED - 1 more needed] Re: [Patch] Hover over icons produces the wrong behavior · Fridrich Strba

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.