Hi Cedric,
On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote:
could you please review / push this patch to 3.4 and 3.4.0? It's a
simple fix that would save quite some crashes.
Looks fine to me - of course I'd prefer:
- xub_StrLen nEndPos = rEnd == rStart ? rEnd.nContent.GetIndex() : rEnd.nContent.GetIndex()
- 1;
+ xub_StrLen nEndPos = MAX (0, rEnd.nContent.GetIndex() - 1);
which looks like it might do the same thing ? ;-)
But - you have my review ...
ATB,
Michael.
--
michael.meeks@novell.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.