Re: [Libreoffice] [REVIEW] Crasher fix for fdo#37252

On Tue, May 17, 2011 at 8:09 PM, Kohei Yoshida <kohei.yoshida@gmail.com> wrote:
> The attached patch fixes a crasher reported in
>
> https://bugs.freedesktop.org/show_bug.cgi?id=37252
>
> The original code always assumed that the find call on the map
> container always finds a match (as it didn't check against the end
> iterator after the call returns), but apparently in some cases no
> match can be found.  The attached patch simply checks for the end
> iterator position, and if no match is found, it simply returns right
> there.
>
> I'd like to commit this into the 3.4 branch and the 3.4.0 branch as
> well (if we've already branched).

+1
Looks sane to me.

Norbert

> Thanks,
>
> Kohei
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice