Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Christina,

On Tue, 2011-05-17 at 09:29 +0200, Chr. Rossmanith wrote:
Am 16.05.2011 17:05, schrieb Michael Meeks:
On Fri, 2011-05-06 at 21:53 +0200, Chr. Rossmanith wrote:
I think the variable nColor from struct HTML_ColorEntry in htmlkywd.cxx
can be changed from sal_uLong to sal_uInt32. Continue to change return
..
Of course. Find it attached.

        It looks nice :-) then again - I noticed this mess:

#if defined( WNT )
 __cdecl
#endif
#if defined( ICC )
 _Optlink
#endif

        Which (you would hope) would be implied by the extern "C" { } construct
on Windows - with a SAL_CALL macro annotation instead :-) That won't
work for ICC - but - our ICC support is almost certainly broken anyway
and I doubt anyone cares.

        It seems there are a load of other #if defined WNT - conditionals
around __cdecl in similar circumstances that'd be great to fix if you
have the energy :-)

        Thanks !

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.