[Libreoffice] Duplicate code: replace mbBreak with hasLineBreak?

"Chr. Rossmanith" <ChrRossmanith -AT- gmx.de>

Mon, 16 May 2011 09:37:10 +0200

Hi, I had a closer look at output2.cxx. (1) ScOutputData::DrawEditTopBottom tests "if (rParam.hasLineBreak())" (2) ScOutputData::DrawEditBottomTop tests "if (rParam.mbBreak)" with bool ScOutputData::DrawEditParam::hasLineBreak() const {

return (mbBreak || (meOrient == SVX_ORIENTATION_STACKED) ||

mbAsianVertical);

}

so (2) is more restrictive than (1). Would it be valid to have

rParam.hasLineBreak() in (2) as well?

Thank you, Christina

Context

[Libreoffice] Duplicate code: replace mbBreak with hasLineBreak? · Chr. Rossmanith

Re: [Libreoffice] Duplicate code: replace mbBreak with hasLineBreak? · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.