I'd like to commit the attached patch to the 3.4 branch. This was
discovered by the unit test which failed when an empty matrix element
didn't have a value of 0.0. As it turned out, I was initializing the
higher 4 bytes via 32-bit pointer but the lower 4 bytes were left
un-initialized, which caused the double value to become non-zero.
Apparently this doesn't happen when building a 64-bit build.
Thanks,
Kohei
Attachment:
0001-Properly-initialize-and-copy-fVal.patch
Description: Binary data
Context
- [Libreoffice] [REVIEW] Proper initialization and copying of union matrix value. · Kohei Yoshida
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.