Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index



On Sat, 2011-05-07 at 13:03 -0430, Rafael Dominguez wrote:
Well it does look weird, but its the same object getting compared on
both sides, so i think theres a problem there, but better wait for
someone with more experience in the code say something about it.

        In libreoffice-3-3 we had:

#if CHART_ADDRESS_CONV_WORKAROUND
        ::formula::FormulaGrammar::AddressConvention eConvUI = pDocument->GetAddressConvention();
        if (eConv != eConvUI)
            return ((rAddress.Parse(sToken, const_cast<ScDocument*>(pDocument), eConvUI) & 
SCA_VALID) == SCA_VALID);
#endif

        Around here instead of:

            if (!bResult && eConv != eConv)
                bResult = ((rRange.aStart.Parse(
                    aUIString, const_cast<ScDocument*>(pDocument), eConv) & SCA_VALID) == 
SCA_VALID);

        It seems pretty bogus doing the same parse again - you would hope the
function would fail in the same way :-)

        Best to ask Kohei to de-louse it though :-) nice catch ...

        HTH,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.