Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Christian,

On Fri, 2011-05-06 at 04:25 +0200, Christian Lohmaier wrote:
Looking at this change (as it breaks with WaE because that function is
unused on Mac)

        :-) glad you're on that.

Fix for the WaE breaker is easy (just conditionalize it for non-mac as
in the exec_pagein method), but the code did let me stumble, so I take
the opportunity to learn and ask....

        Yep - AFAICS we don't use ooqstart.bin on Mac - so I've never quite
understood why we bother with it [ or do we use it - I would be amazed
it has a fairly hard X dependency ;-]. It would be better to remove it
altogether I think.

+#define REL_PATH "/../basis-link/program"
..
+    strcat (path, "/../basis-link/program/");

        As you say- that should be REL_PATH too.

slash - so sizeof counts one character less (OK, no problem, account

        sizeof counts one char more - with the nullbyte.

And the second part is - why the "+8"?

        paranoia :-) with the kind of crazies editing the code that we have
around here, some of it can be a good thing.

What am I missing? /me feels dumb, and fears the answer :-))

        Nothing - you're golden :-) it'd be great if you could clean it up on
master.

        Thanks !

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.