Re: [Libreoffice] [REVIEW] Easyhack Add visibility markup to all component_get* functions

Hi Julien,

On Thu, 2011-04-21 at 16:28 +0200, Julien Nabet wrote:
> I think i modified all the functions 
> "component_getImplementationEnvironment" and "component_getFactory" get 
> for the easyhack

        Nice :-)

> It compiled ok each time I push the changes but I didn't make a 
> compilation from scratch.

        Great; that should be fine.

> I saw helpers in the code, for example in 
> cppuhelper/inc/cppuhelper/factory.hxx, there's this :
> #define COMPONENT_GETFACTORY            "component_getFactory"
> #define COMPONENT_GETENV                        
> "component_getImplementationEnvironment"

        Ok - those are just the strings to lookup.

> typedef void * (SAL_CALL * component_getFactoryFunc)(
>      const sal_Char * pImplName, void * pServiceManager, void * 
> pRegistryKey );
> typedef void (SAL_CALL * component_getImplementationEnvironmentFunc)(
>      const sal_Char ** ppEnvTypeName, uno_Environment ** ppEnv );

        Those are function pointer typedefs, so no problem here.

> If you consider this easyhack is finished, i can update the wiki pages.

        Yes ! please do - and sorry for the delay :-)

        Good work,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot