Re: [Libreoffice] [PATCH][PUSHED] Fix cppcheck warnings in components (easy hack)

Katarina Machalkova <kmachalkova -AT- suse.cz>

Thu, 28 Apr 2011 14:08:02 +0200

The attached patch fixes lots of cppcheck warnings in the components
repository.

Thanks! All of those are good points. Just small nitpicking (cui/source/dialogs/thesdlg.cxx) -- I did the following change to your patch: - (aLookUpHistory.empty() == 0 || aLookUpText != aLookUpHistory.top())) + (aLookUpHistory.empty() || aLookUpText != aLookUpHistory.top())) ie. it is OK to use just empty(), as aLookUpHistory is std::stack and this call returns bool. No need to additionally compare it to zero.

By the way, did anybody review my latest pyuno patch update? Or am I not
patient enough :)

Nope, or so it seems. As a person in charge of integrating patches this week, I didn't spot it, because I usually look for [PATCH] keyword in e-mail subject. Sorry about that. Someone speaking Python will have look at it in due course. Keep up good work! :) B. -- \\\\\ Katarina Machalkova \\\\\\\__o LibO developer __\\\\\\\'/_ & hedgehog painter

Attachment: signature.asc
Description: This is a digitally signed message part.

Context

[Libreoffice] [PATCH] Fix cppcheck warnings in components (easy hack) · Andreas Becker

Re: [Libreoffice] [PATCH][PUSHED] Fix cppcheck warnings in components (easy hack) · Katarina Machalkova

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.