Re: [Libreoffice] Objective C in slideshow

On Sat, Apr 23, 2011 at 12:34 PM, Christian Lohmaier
<lohmaier+libreoffice@googlemail.com> wrote:
> Hi *,
>
>
> Thanks a lot, some nitpick
> cc1obj: warning: command line option "-fno-enforce-eh-specs" is valid
> for C++/ObjC++ but not for ObjC
>
> i.e. would be nice if that flag would be stripped for ObjC compiles

yep, objC should probably not take gb_LinkTarget_EXCEPTIONFLAGS (below
patch pushed):

diff --git a/slideshow/Library_OGLTrans.mk b/slideshow/Library_OGLTrans.mk
index 4a94e9c..3a04c1e 100644
--- a/slideshow/Library_OGLTrans.mk
+++ b/slideshow/Library_OGLTrans.mk
@@ -66,7 +66,7 @@ ifeq ($(strip $(OS)),MACOSX)
 $(eval $(call gb_Library_add_objcobjects,OGLTrans,\
     slideshow/source/engine/OGLTrans/mac/aquaOpenGLView \
     slideshow/source/engine/OGLTrans/mac/OGLTrans_Shaders \
-    , $(gb_LinkTarget_EXCEPTIONFLAGS) \
+    ,\
 ))

 $(eval $(call gb_Library_add_objcxxobjects,OGLTrans,\

> Probably unrelated to your fix:
> Slideshow unfortunately is not buildable with that change yet
> (although it now doesn't longer break because of the missing symbol) -
> it does a copy with only one file parameter:
>
> tinderbox-buildslave:~/compile/libreoffice/slideshow buildslave$
> /Users/buildslave/make_prefix/bin/make -r
> R=/Users/buildslave/compile && S=$R/libreoffice &&
> O=$S/solver/300/unxmacxp.pro && W=$O/workdir &&  mkdir -p $O/lib/ &&
> rm -f $O/lib/libavmediamxp.dylib &&
> cp -f  $O/lib/libavmediamxp.dylib &&
> touch -r  $O/lib/libavmediamxp.dylib
> usage: cp [-R [-H | -L | -P]] [-f | -i | -n] [-pv] src target
>       cp [-R [-H | -L | -P]] [-f | -i | -n] [-pv] src1 ... srcN directory
> make: *** [/Users/buildslave/compile/libreoffice/solver/300/unxmacxp.pro/lib/libavmediamxp.dylib]
> Error 64
>
> i.e. the source is missing..

humm weird, I do no see this one on MacIntel .. let me retry a clean
build just to be sure...

> ciao
> Christian