Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Markus,

On Fri, 2011-04-22 at 19:29 +0200, Markus Mohrhard wrote:
Hello Kohei,

yes you're right. This part was copied from another method and I
didn't notice it. But I don't think that you must check for
ScDocShell, because the whole class is build without any check for it.

Agreed.  The chances of pDocShell being NULL there are next to nothing,
so it's probably fine not checking its value.  I wouldn't either.

Should I send a reworked patch?

Nah.  Don't bother. ;-)  It's not that big deal anyway.

Thanks.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.