Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello,

Following a discussion on IRC with Llunak, here is a problem.
In the main function of libs-core/desktop/source/app/app.cxx Line 1599, there's a declaration+init variable :
int nAcquireCount( 0 );

then nothing until this line 1880 :
if (nAcquireCount)
    Application::AcquireSolarMutex( nAcquireCount );

Llunak talked about a wrong commit,b58863e8ddc923fa737d064b873b8099a24a8c51

I think this line "nAcquireCount = Application::ReleaseSolarMutex() - 1;" should be added before the line 1850 :
if ( !bTerminateRequested && !rCmdLineArgs.IsInvisible() &&)

but
1) Before this line, there was also :
::vos::IMutex& rMutex = Application::GetSolarMutex();
if ( rMutex.tryToAcquire() )

I don't know if these are still useful

2) in the function doShutdown, there's only on line 1947 :
sal_uLong nAcquireCount = Application::ReleaseSolarMutex();

So i don't know too if -1 is necessary or not

Any idea ?

Julien

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.