Re: [Libreoffice] ld dynamic linker hash style

Francois Tigeot píše v St 06. 04. 2011 v 17:04 +0200:
> On Wed, Apr 06, 2011 at 03:59:34PM +0200, Petr Mladek wrote:
> > I have found that there already was a check for --hash-style. So, I used
> > your draft and itegrated it into the existing test, see
> > http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4&id=34e8665b5d3544c48086701d9f758ef0b9d900f8
>
> Er, wrong move :-(
>
> > Please, do not feel offended that I did not use your patch as is. The
> > patch was nice but needed more love.
>
> I'm well aware of that, I'm no autoconf specialist and it was a
> work-in-progress.
>
> Let me be offended on a different point ;-)
>
> the test you have reused and the one I just wrote are for two different things.
> We have two things here:
>
> - the first check tested for --hash-style=gnu option support.
>   ld supports it, result = yes

If you look at my change, I have removed this check. IMHO, it is
obsoleted by the AC_TRY_RUN one. ;-)

AC_TRY_LINK compiles and links the program.
AC_TRY_RUN compiles, links, and run the program.

IMHO, it does not make sense to enable --hash-style=gnu if the
application can be linked and not started on the given system. So, the
AC_TRY_LINK is not needed because the same success/failure is detected
also by AC_TRY_RUN.

> - the check I just wrote tested if binaries linked with the --hash-style=gnu
>   can be run
>   something in the system doesn't grok it, result = no
>
> By integrating the two autoconf checks, we're back to a situation where
> the build process happily links binaries with --hash-style=gnu and crashes
> a few moments later trying to run them.

Are you sure? Have you looked at my changes? :-)

> What I wanted to do is set a reasonable default of "gnu" or "sysv" for the
> --with-hash-style option depending if the machine can run such binaries or
> not.

I hope that I did the same. The only difference might be that my
approach does not care only about the default. In addition, it does not
allow to force "gnu" on systems that are able to link but are not able
to run such programs. IMHO, it does not make much sense. It would even
cause compilation problems because some helper tools need are compiled
and ran during build. Or did I miss anything?


Best Regards,
Petr