Re: [Libreoffice] Patch for supporting one autofilter per sheet

Hi Kohei & Markus,

On Wed, 2011-03-30 at 16:57 -0400, Kohei Yoshida wrote:
> Markus has been working on the easy hack to support one autofilter per
> sheet, instead of per document, and it is to a state where it is
> fairly usable.  The patch against the current master is attached.

        Great news ! :-)

> We have been working on this on and off to sort out many issues, and
> I'm happy to see his work finally coming to fruition.  What I would
> like to do from this point on is to give it more intensive testing
> to weed out any remaining issues and extra polish, and hopefully
> get this piece in

        Presumably the best way to get that is to check it into master, and
then encourage our QA guys to bang on it :-) at least - I'd like it in
before our feature freeze ~tomorrow [ and as one commit it is presumably
easy to revert if something catastrophic comes up - though it sounds
like this is unlikely ].

        I accidentally read the last fragment:

On Wed, 2011-03-30 at 16:57 -0400, Kohei Yoshida wrote:
> @@ -736,7 +737,7 @@ void ScCellShell::ExecuteDB( SfxRequest& rReq )
>  
> -                                if ( *pDBName != aStrNoName )
> +                                if ( *pDBName!=aStrNoName )

        And am not a fan of gratuitous whitespace change ;-) but hey - you get
to do the merging Kohei.

        Thanks so much Markus ! I'm looking forward to your next hack.

        Regards,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot