[Libreoffice] [PUSHED] Re: [PATCH] fix obvious bug in VCL that prevent glyph-fallback for one glyph-missing character at the end of string

Caolán McNamara <caolanm -AT- redhat.com>

Thu, 24 Mar 2011 15:30:45 +0000

On Thu, 2011-03-24 at 21:27 +0700, Samphan Raruenrom wrote:

While working on other bugs, we found this bug in
vcl/win/source/gdi/salgdi3.cxx b/vcl/win/source/gdi/salgdi3.cxx . When
there is only one character at the end of the string that require
glyph-fallback, the bug prevent glyph-fallbacking. Because the code
will not detect that the last character need glyph-fallback. It is an
obvious bug because of wrong loop's terminating condition checking.

Please take a look.

Looks good to me, makes sense. Pushed now, thanks for this. C.

Context

[Libreoffice] [PATCH] fix obvious bug in VCL that prevent glyph-fallback for one glyph-missing character at the end of string · Samphan Raruenrom

[Libreoffice] [PUSHED] Re: [PATCH] fix obvious bug in VCL that prevent glyph-fallback for one glyph-missing character at the end of string · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.