Re: [Libreoffice] Doubt about bogus and commented code

Hi Xisco,

On 2011-03-12 at 02:25 +0100, Xisco Faulí wrote:

> I've seen quite often something like this:
>
> -/*
> - #i2345#
> - if ( nSlotId >= SID_SFX_START && !
> SfxMenuManager::IsPopupFunction(nSlotId) )
> - {
> - // Echte Popups sollen keine SlotIds haben; leider sind
> - // da noch Altlasten mit herumzuschleppen ...
> - String aTitle = pSVMenu->GetItemText( nSlotId );
> - pSVMenu->SetPopupMenu( nSlotId, NULL );
> - USHORT nPos = pSVMenu->GetItemPos( nSlotId );
> - pSVMenu->RemoveItem( nPos );
> - nSlotId = 1;- while ( pSVMenu->GetItemPos(nSlotId) !=
> MENU_ITEM_NOTFOUND ) - nSlotId++; - pSVMenu->InsertItem( nSlotId,
> aTitle, 0, nPos ); - pSVMenu->SetPopupMenu( nSlotId, pPopup ); - } -*/
> What should I do with it ? leave it like that ? delete it completery ?
> or delete the code and leave the bogus ?

Delete entirely :-)

> Btw, what about the peaces which say, FIXME ?

Do you have an example, please?

Regards,
Kendy