Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi David,

I am assuming you are working on an improved version of the patch taking
Cedric comments into consideration.

Thank you so much for your contributions! Looking forward for more...

- Muthu Subramanian

On 03/08/2011 02:21 PM, Cedric Bosdonnat wrote:
Hi Muthu, David,

On Mon, 2011-03-07 at 21:46 +0530, Muthu Subramanian K wrote:
Hi David,

Thank you for you patch.
The general rule is to keep the "i####" kind of numbers - these are
issuezilla ids. But, in this case I would prefer to go with you to
remove most of these - since, in this patch context, the ids seem to
have been added to every line.

On the other hand, I would prefer another person reviewing before I push
these changes - cedric?

I would keep the #i91601# before one FN_UNO_LIST_ID to show it has been
added to fix that bug, but remove the other instances. IMHO quite a lot
of #i123456# comments would be lost: these need to be kept in at least
some strategic places.



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.