Re: [Libreoffice] flat directory structure in master is bad for l10n

Andras Timar píše v Út 08. 03. 2011 v 10:56 +0100:
> Hi,
>
> I'm working on the PO based localization. There is a step where I need
> to extract a fresh en-US.sdf from the source. However, if the directory
> structure is completely flat - as it is in master - the localize tool
> goes into all subdirectories in SOURCE_ROOT_DIR including clone and
> install. Therefore it extracts every string at least twice. If we had a
> build directory and we linked the modules there, this problem would not
> be present.
>
> Alternatively it should be fixed in
> libs-gui/l10ntools/source/localize.cxx. The current approach is
> sub-optimal anyway, because localize searches all directories for
> localizable content. Obviously many modules don't contain localizable
> content so we can save a lot of I/O operations, if we tell the tool
> explicitly where to search.
>
> Please let me know what you think.

I suggest to go with the alternative solution. There are already white
and black lists for particular files in
libs-gui/l10ntools/source/localize.cxx. We just need to add a similar
mechanism for directories.

Regarding the flat structure. Some developers might prefer the sorting
into 20 git modules. Though, I think that it is still easier to move
between the various modules in the flat structure. If it is used by most
people, it does not make sense to hide it in a subdirectory.


Best Regards,
Petr