Re: [Libreoffice] [PATCH] [PUSHED] One bool mistake in msfilter

Kohei Yoshida <kohei.yoshida -AT- gmail.com>

Sat, 5 Mar 2011 15:02:12 -0500

Hi Arnaud, On Fri, Mar 4, 2011 at 7:17 AM, Arnaud Versini <arnaud.versini@gmail.com> wrote:

Hello,

This verry small patch replace BOOL by bool for bRetValue.

Thanks. Pushed to master.

Can I replace all BOOL from msfilter to bool?

Sure, why not. But please don't do a blind replacement of all BOOL's to bool, and at least check each case to make sure that BOOL is used truly as a boolean value. Sometimes some people abused the fact that BOOL was a typedef to char, and used it as an integer, in which case we should replace it by an integer type not bool. Kohei

Context

[Libreoffice] [PATCH] One bool mistake in msfilter · Arnaud Versini

Re: [Libreoffice] [PATCH] [PUSHED] One bool mistake in msfilter · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.