Re: [Libreoffice] [REVIEW] Backport to libreoffice-3-3

On Thu, 2011-03-03 at 17:46 +0100, Thorsten Behrens wrote:
> Kohei Yoshida wrote:
> > I'd like to cherry-pick the following commit
> >
> > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=63f695b8cf3572c2697abcfe99e2e7d5da923e9b
> >
> > to the libreoffice-3-3 branch.
> >
> > This fixes
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=33756
> Hi Kohei,
>
> um, bit hard to assess this one, as you already noted, with the
> renaming & all - any chance to have a minimal patch instead for
> -3-3? Otherwise, I'd here defer to your greater wisdom - if that
> fixes more crashes than it potentially introduces, go for it. ;)

Ok.  Well, the commit is rather old, and it'd take sometime for me to
clean it up.  So, I'd rather we take the chance and trust me on this
backport.  The existing code is clearly wrong, and the change to me is
no brainer.  If this is any consolation, I wrote the original code (it's
100% mine), and I'm patching my own code.  So I'd like to think that I
know what I'm doing with this change. :-)

Also, this code only gets executed during keyboard based range selection
i.e. Shift+<arrow key>.  So, it has a very limited scope.

Unless I hear otherwise from you, I'll take that you are giving me a
sign-off on this.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>