Re: [Libreoffice] [PATCH] Remove legacy Addin mechanism from calc

Hi Regina,

I understand that this addin mechanism was used to add functions to calc. I 
wasn't aware of whether it was used that much.
The general consensus, before implementing the patch, was that it wasn't 
probably used that much. In fact, it was marked and "deprecated" back in 2006.

However, I can't determine whether this is something that we can or can't 
remove. I just went ahead with the patch based on feedback from Michael, Kohei 
and Caolan.

If the final decision is to throw the patch away and keep things the way they 
are, that is not a problem.
I think it is a good thing that we have this other perspective on the subject.

Regards,
Alfonso

----- Original Message ----

Hi Alfonso,

Alfonso Eusebio schrieb:
> Hi,
>
> Please find attached two patches for the removal of the legacy Addin Mechanism
> from calc.
> One of the patches removes the code from binfilter. I have now read what this
> module is about and I guess it might not have been necessary to remove stuff
> from here, but I hope this will keep it aligned with calc.
>
> As always, these changes are made available under LGPLv3+/MPL.
>
> I have rebased, compiled and tested scalc after the changes. I've had no 
issues
> with uploading spreadsheets and creating formulas with scaddin functions.
> If there is a more systematic way of testing this, or some documents that 
could
> be used to test that everything still works, please let me know.

The old scaddin is different from using functions of the "Add-in" 
category of the wizard. It is about writing own functions, that are 
wrapped into a dll. The issue
http://www.openoffice.org/issues/show_bug.cgi?id=98149
has attached such an addin.

Kind regards
Regina