Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Now I'm sure. It's unused. But the question is, if we want to use
GetListTable() in DomainMapper class to replace pImpl->GetListTable()
with GetListTable(). Could be the case, that this was prepared to. But
wouldn't make anything better ;) So I pushed it, thanks!

Thomas

On 02/14/2011 05:49 PM, Thomas Arnhold wrote:
Hi Balint,

looks good. I've pushed the second one. I slightly changed your patch -
removed the newlines for the empty methods and didn't remove the
description in writerfilter/inc/doctok/WW8Document.hxx as this is some
kind of doxygen code.

For the first patch, which removes the method, I'm not fully sure. I've
applied it locally and it compiles fine. But it would be great if
someone else could review this, too.

Thomas

On 02/14/2011 12:49 PM, Bálint Dózsa wrote:
Hy,

I have removed some dead code (0002-Remove-dead-code.patch), and one
unused method (0001-Remove-unused-method-GetListTable.patch).

Regards,
Balint Dozsa



_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.