Re: [Libreoffice] REVIEW: EMF+ disable on Win32 ...

Hi,

the patch looks OK to me.

Cheers
Radek

On Fri, 2011-02-11 at 12:17 +0000, Michael Meeks wrote:
> Hi guys,
>
>       Talking to Radek (wrt. the EMF+ previews missing in action - ie. we
> just get white images (apparently)) - from bug:
>
>       https://bugs.freedesktop.org/show_bug.cgi?id=33785
>
>       It seems that the quick workaround is appended;
>
> diff --git a/svtools/source/filter.vcl/wmf/enhwmf.cxx b/svtools/source/filter.vcl/wmf/enhwmf.cxx
> index cc50b1b..1dd5c64 100644
> --- a/svtools/source/filter.vcl/wmf/enhwmf.cxx
> +++ b/svtools/source/filter.vcl/wmf/enhwmf.cxx
> @@ -348,7 +348,7 @@ BOOL EnhWMFReader::ReadEnhWMF()
>      static sal_Bool bEnableEMFPlus = ( getenv( "EMF_PLUS_DISABLE" ) == NULL );
>  #else
>      // TODO: make it possible to disable emf+ on windows
> -    static sal_Bool bEnableEMFPlus = sal_True;
> +    static sal_Bool bEnableEMFPlus = sal_False;
>  #endif
>  
>      while( bStatus && nRecordCount-- )
>
>       And hopefully, then we will fall back (where it is present) to the EMF
> (not EMF+) or WMF preview instead.
>
>       Jesus - it'd be wonderful if you could do a test of that (?) otherwise,
> other reviews appreciated.
>
>       Tor - rumour has it that you looked at getting this working on Windows,
> the interaction is with vcl/source/gdi/gdimtf.cxx incidentally and some
> UNO-ised canvas pieces I guess.
>
>       Thanks,
>
>               Michael.