Re: [Libreoffice] [PATCH] [PUSHED] Remove obsolete Hyperlink Bar from calc

Hi Kohei,

Thanks for you support.

I've created a small patch that removes the references to hyperlink header files 
(includes).
Please find that patch attached. Changes provided under LGPLv3+/MPL.

I'll be sending the patches for impress, draw and write shortly on separate 
emails.

Regards,
Alfonso



----- Original Message ----
From: Kohei Yoshida <kyoshida@novell.com>
To: Alfonso Eusebio <alfonso_eusebio@yahoo.co.uk>
Cc: LibreOffice List <libreoffice@lists.freedesktop.org>
Sent: Wed, 9 February, 2011 2:45:50
Subject: Re: [Libreoffice] [PATCH] [PUSHED] Remove obsolete Hyperlink Bar from 
calc

Hi Alfonso,

On Tue, 2011-02-08 at 21:41 +0000, Alfonso Eusebio wrote:

> Please find attached patch that removes the Hyperlink Bar from calc (made 
> available under LGPLv3+/MPL).
> Patch has been rebased with origin/master and compiled before submission.

Looks all good. Pushed.

> I've started removing the references to the Hyperlink Bar from the apps. Once 
> that's done I'll remove the implementation and menu entries in core modules.
> After applying this patch the menu entry to activate the bar is still present 
> but greyed out. This should dissapear once core modules are done.
> I'll be making one patch per app/module.

Gotcha.  I like your strategy.  Go for it!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>


From 1a65472f1c35c8bb456e0611c8133cba77d785f6 Mon Sep 17 00:00:00 2001
From: Alfonso Eusebio <alfonso_eusebio@yahoo.co.uk>
Date: Wed, 9 Feb 2011 17:23:38 +0000
Subject: [PATCH] Remove includes related to Hyperlink Bar from calc

Removed includes for hyperlink headers.
---
 sc/source/ui/app/scdll.cxx |    1 -
 sc/source/ui/app/scmod.cxx |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sc/source/ui/app/scdll.cxx b/sc/source/ui/app/scdll.cxx
index 83f3e96..53e3eb4 100644
--- a/sc/source/ui/app/scdll.cxx
+++ b/sc/source/ui/app/scdll.cxx
@@ -116,7 +116,6 @@
 #include "spelldialog.hxx"
 #include <svx/fontwork.hxx>
 #include <svx/srchdlg.hxx>
-#include <svx/hyprlink.hxx>
 #include <svx/hyperdlg.hxx>
 #include <svx/imapdlg.hxx>
 
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 0b603c7..f384ffa 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -49,7 +49,6 @@
 #include <sfx2/viewfrm.hxx>
 #include <sfx2/objface.hxx>
 
-#include <svx/hyprlink.hxx>
 #include "IAnyRefDialog.hxx"
 
 #include <svtools/ehdl.hxx>
-- 
1.7.1