Re: [Libreoffice] [PATCH] [PUSHED] Removed unused functions and classes from calc 3last

Hi Alfonso,

On Sun, 2011-02-06 at 19:08 +0000, Alfonso Eusebio wrote:

> Please notice that this patch removes three entire classes: 
> ScSummableCompressedArray, ScVbaCharts and ScVbaSeriesCollection.
> For the last two classes the corresponding .cxx and .hxx files have been 
> removed.

Yup, that's the right thing to do.  There is no reason to keep the class
if it's entirely unused.

> This patch has been rebased with origin/master and compiled before submission.
>
> On a related note:
> Several of the unused functions identified by call-catcher live in the addin 
> "module" within calc (calc/sc/addin). These functions seem to be called 
> indirectly by the function add-in mechanism.

Wow.  I never knew this (sc/addin) existed!  And yes, it's also my
understanding that scaddins is the right home for all the add-in
functions.

> I have not removed these functions, however, it seems that this "addin" module 
> is obsolete now, with the scaddins (calc/scaddins) module replacing it (?).
> In any case, if somebody can confirm that the "addin" module can be removed, I 
> could work on it.

I can't be 100% certain of this.  But if you can build sc and scaddins
without the sc/addin directory, then I'm in favor of removing it.  Looks
like no one has touched this since 2000, so it's probably obsolete.

So, please check if it's buildable, and go for removing it if the answer
is yes.

BTW, I've pushed your patch on master.  Thanks a lot!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>