Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index 

Hi Andrey,


This is my first patch to LibreOffice so I'd be grateful for feedback on any 
issues.


Oddly enough, I was looking at this the other day but didn't get round
to submitting a patch because I couldn't get sw to compile (for totally
unrelated reasons). My changes were almost identical to yours, though I
have one suggestion.

Changing to a std::pair means we go from descriptively named items
(aNodeIdx and aLevels) to the generic first/second. Which is less clear
to the reader. Can I suggest you either:

A) Add a comment above the SvNode definition to say (very briefly) what
the ULONG and int are used for.

or:

B) Define a local class/struct instead of the pair with more descriptive
names for the elements.

Nigel

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.