On Tue, 2011-02-01 at 13:57 -0500, Jonathan Callen wrote:
The attached patch replaces usage of LinkList (declared as
DECLARE_LIST(LinkList, Link*) with std::list<Link>.
I used list<Link> instead of list<Link*> because 1) the elements of the
list were only ever used from within the .cxx file declaring the list
itself and 2) each element was already allocated on addition and
deallocated on removal, so I just made that more explicit by letting
std::list handle it.
Looks good. Pushed.
BTW, I will not push your 2nd patch that replaces some of the iterator
loops with BOOST_FOREACH. As we talked about this on IRC, I don't like
the idea of replacing one macro with another, even if the documentation
page claims this to be a "good-behaving macro".
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.