Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Can someone explain me why my patch has not been pushed ?
If I were wrong somewhere, I don't want to make the same mistake twice.
It was my first (really easy/small) patch, to learn how to procede fine.
--- Begin Message ---
Hi, I removed some empty lines in few files for my first patch.
I'll continue if it's ok.

Regards
Guillaume
From b4a7a9c01d535e6e0ab0c8324458494bcd757409 Mon Sep 17 00:00:00 2001
From: Guillaume Fillol <guillaume.fillol@lello.fr>
Date: Sat, 29 Jan 2011 00:14:19 +0100
Subject: [PATCH] Easy hacks: remove double line spacing

---
 binfilter/bf_xmloff/source/draw/ximpshap.hxx       |   11 +-----
 .../bf_xmloff/source/draw/xmloff_sdpropls.cxx      |   39 +-------------------
 .../bf_xmloff/source/draw/xmloff_sdxmlimp.cxx      |   21 -----------
 .../text/xmloff_XMLTrackedChangesImportContext.cxx |   10 -----
 4 files changed, 2 insertions(+), 79 deletions(-)

diff --git a/binfilter/bf_xmloff/source/draw/ximpshap.hxx 
b/binfilter/bf_xmloff/source/draw/ximpshap.hxx
index 6001284..d5b5079 100644
--- a/binfilter/bf_xmloff/source/draw/ximpshap.hxx
+++ b/binfilter/bf_xmloff/source/draw/ximpshap.hxx
@@ -30,26 +30,17 @@
 #define _XIMPSHAPE_HXX
 
 #include <com/sun/star/io/XOutputStream.hpp>
-
 #include <com/sun/star/document/XActionLockable.hpp>
-
 #include <com/sun/star/container/XIdentifierContainer.hpp>
-
 #include "xmlictxt.hxx"
-
 #include "sdxmlimp_impl.hxx"
-
 #include "nmspmap.hxx"
-
 #include <com/sun/star/drawing/XShapes.hpp>
-
 #include <com/sun/star/text/XTextCursor.hpp>
-
 #include <com/sun/star/awt/Point.hpp>
-
 #include <tools/rtti.hxx>
-
 #include "xexptran.hxx"
+
 namespace binfilter {
 
 //////////////////////////////////////////////////////////////////////////////
diff --git a/binfilter/bf_xmloff/source/draw/xmloff_sdpropls.cxx 
b/binfilter/bf_xmloff/source/draw/xmloff_sdpropls.cxx
index 2df127d..6987079 100644
--- a/binfilter/bf_xmloff/source/draw/xmloff_sdpropls.cxx
+++ b/binfilter/bf_xmloff/source/draw/xmloff_sdpropls.cxx
@@ -31,81 +31,44 @@
 #endif
 
 #include <com/sun/star/ucb/XAnyCompareFactory.hpp>
-
 #include <com/sun/star/container/XIndexReplace.hpp>
-
 #include <com/sun/star/drawing/LineStyle.hpp>
-
 #include <com/sun/star/drawing/LineJoint.hpp>
-
 #include <com/sun/star/drawing/FillStyle.hpp>
-
 #include <com/sun/star/presentation/AnimationSpeed.hpp>
-
 #include <com/sun/star/presentation/FadeEffect.hpp>
-
 #include <com/sun/star/drawing/ConnectorType.hpp>
-
 #include <com/sun/star/drawing/RectanglePoint.hpp>
-
 #include <com/sun/star/drawing/CircleKind.hpp>
-
 #include <com/sun/star/drawing/BitmapMode.hpp>
-
 #include <com/sun/star/text/WritingMode.hpp>
-
 #include <EnumPropertyHdl.hxx>
-
 #include <NamedBoolPropertyHdl.hxx>
-
 #include "numithdl.hxx"
-
 #include "XMLBitmapRepeatOffsetPropertyHandler.hxx"
-
 #include "XMLFillBitmapSizePropertyHandler.hxx"
-
 #include "XMLBitmapLogicalSizePropertyHandler.hxx"
-
 #include <com/sun/star/drawing/TextAnimationKind.hpp>
-
 #include <com/sun/star/drawing/TextAnimationDirection.hpp>
-
 #include <com/sun/star/drawing/TextHorizontalAdjust.hpp>
-
 #include <com/sun/star/drawing/TextVerticalAdjust.hpp>
-
 #include <com/sun/star/drawing/TextFitToSizeType.hpp>
-
 #include <com/sun/star/drawing/MeasureTextHorzPos.hpp>
-
 #include <com/sun/star/drawing/MeasureTextVertPos.hpp>
-
 #include "ControlBorderHandler.hxx"
-
-
 #include "sdpropls.hxx"
-
 #include "propimp0.hxx"
-
 #include "xmlexp.hxx"
-
 #include <xmlnmspe.hxx>
-
 #include <com/sun/star/drawing/NormalsKind.hpp>
-
 #include <com/sun/star/drawing/TextureProjectionMode.hpp>
-
 #include <com/sun/star/drawing/TextureKind.hpp>
-
 #include <com/sun/star/drawing/TextureMode.hpp>
-
 #include "txtprmap.hxx"
-
 #include "XMLClipPropertyHandler.hxx"
-
 #include "XMLIsPercentagePropertyHandler.hxx"
-
 #include "XMLPercentOrMeasurePropertyHandler.hxx"
+
 namespace binfilter {
 
 using namespace ::rtl;
diff --git a/binfilter/bf_xmloff/source/draw/xmloff_sdxmlimp.cxx 
b/binfilter/bf_xmloff/source/draw/xmloff_sdxmlimp.cxx
index 783940c..b44cc6d 100644
--- a/binfilter/bf_xmloff/source/draw/xmloff_sdxmlimp.cxx
+++ b/binfilter/bf_xmloff/source/draw/xmloff_sdxmlimp.cxx
@@ -31,38 +31,19 @@
 #endif
 
 #include "xmlscripti.hxx"
-
-
-
 #include "ximpbody.hxx"
-
 #include "xmlmetai.hxx"
-
 #include "ximpstyl.hxx"
-
 #include "xmlnmspe.hxx"
-
-
 #include "xmluconv.hxx"
-
 #include "DocumentSettingsContext.hxx"
-
 #include <com/sun/star/form/XFormsSupplier.hpp>
-
 #include <com/sun/star/document/XDocumentInfoSupplier.hpp>
-
-
 #include <com/sun/star/style/XStyleFamiliesSupplier.hpp>
-
 #include <com/sun/star/drawing/XMasterPagesSupplier.hpp>
-
 #include <com/sun/star/drawing/XDrawPagesSupplier.hpp>
-
-
-
 #include "xmlerror.hxx"
 
-
 namespace binfilter {
 
 using namespace ::rtl;
@@ -956,7 +937,6 @@ OUString SAL_CALL SdXMLImport::getImplementationName() throw( uno::RuntimeExcept
     if( IsDraw())
     {
         // Draw
-
         switch( getImportFlags())
         {
             case IMPORT_ALL:
@@ -976,7 +956,6 @@ OUString SAL_CALL SdXMLImport::getImplementationName() throw( uno::RuntimeExcept
     else
     {
         // Impress
-
         switch( getImportFlags())
         {
             case IMPORT_ALL:
diff --git a/binfilter/bf_xmloff/source/text/xmloff_XMLTrackedChangesImportContext.cxx 
b/binfilter/bf_xmloff/source/text/xmloff_XMLTrackedChangesImportContext.cxx
index 6dbb679..ebe446d 100644
--- a/binfilter/bf_xmloff/source/text/xmloff_XMLTrackedChangesImportContext.cxx
+++ b/binfilter/bf_xmloff/source/text/xmloff_XMLTrackedChangesImportContext.cxx
@@ -27,32 +27,22 @@
  ************************************************************************/
 
 #include "XMLTrackedChangesImportContext.hxx"
-
 #include "XMLChangedRegionImportContext.hxx"
-
 #include <com/sun/star/uno/Reference.h>
-
 #include <com/sun/star/uno/Sequence.h>
-
 #include "xmlimp.hxx"
-
 #include "xmlnmspe.hxx"
-
 #include "nmspmap.hxx"
-
 #include "xmluconv.hxx"
 
 namespace binfilter {
 
-
 using ::rtl::OUString;
 using ::com::sun::star::uno::Reference;
 using ::com::sun::star::uno::Sequence;
 using ::com::sun::star::xml::sax::XAttributeList;
 using namespace ::binfilter::xmloff::token;
 
-
-
 TYPEINIT1( XMLTrackedChangesImportContext, SvXMLImportContext );
 
 XMLTrackedChangesImportContext::XMLTrackedChangesImportContext(
-- 
1.7.1

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

--- End Message ---

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.