Re: [Libreoffice] [PUSHED] cpp cleanliness: fixed some memleaks binfilter

Kenneth Venken <kenneth.venken -AT- gmail.com>
Sat, 29 Jan 2011 23:35:33 +0100

2011/1/28 Michael Meeks <michael.meeks@novell.com>

Hi there,

On Thu, 2011-01-27 at 20:55 +0100, Kenneth Venken wrote:

these patches remove some comments
from ./filters/binfilter/bf_svx/source/editeng/svx_editobj.cxx and


        I've pushed these two.

 fixes two memleaks.


       But this third one looks more problematic to me (at least on the
surface) :-)

       We allocate pC and then store its pointer in aContents (cf.
CreateAndInsertContent) - right ? surely they are freed by
DeleteContents called from the destructor ?

your right. I guess this is a cppcheck false positive.


       Thanks though,

               Michael.

--
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot

Context

[Libreoffice] [PATCH] cpp cleanliness: fixed some memleaks binfilter · Kenneth Venken
- [Libreoffice] [PUSHED] cpp cleanliness: fixed some memleaks binfilter · Michael Meeks
  - Re: [Libreoffice] [PUSHED] cpp cleanliness: fixed some memleaks binfilter · Kenneth Venken
    - Re: [Libreoffice] [PUSHED] cpp cleanliness: fixed some memleaks binfilter · Jesse Adelman

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.