Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello Suguru,

First, many thanks for your patch!

On Thu, 2011-01-27 at 01:43 +0900, suguru hirahara wrote:
I made a patch file. Please notice me if there's any mistake.

Well, you removed entirely some comments containing references to some
public bug reports (they look like #i12345#). In this case we want to
keep them to keep a history.

For example in comments like
// --> OD 2005-12-12 #i27301# - use new type definition for <_nStates>

you keep:
// #i27301# - use new type definition for <_nStates>

Could you please amend your patches to take this comment into account?

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.