On Mon, 2011-01-24 at 09:15 +0000, Andy Holder wrote:
Here are some patches removing unused variables found by cppcheck
Looks good, thanks for these, pushed.
As an aside, there's always a fear in reading these that something like
foo unused = doSomething();
where "unused" is unused gets the entire line removed where
doSomething();
might be the right fix instead. i.e. we still want doSomething, but
don't care about to return value anymore
Though in these cases (0001-cppcheck-unused-variables-writer.patch
0001-cppcheck-Variables-not-used-filters.patch and
0004-ccpcheck-unused-variable-filters.patch) all the methods whose
return value is unused and whose calls are removed by these patches
appear to have no side-effects, so applied.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.