Re: [Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

Hi David,

What's the status of this patch? pushed or needs some tweaks?

--
Cedric


On Fri, 2011-01-21 at 09:39 +0100, David Tardon wrote:
> On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote:
> > On Sat, Jan 15, 2011 at 08:00:05PM +0000, Caolán McNamara wrote:
> > > On Sat, 2011-01-15 at 05:59 +0100, Lionel Elie Mamane wrote:
> > > > Does not fit release blocker criteria, but would still be *very* nice
> > > > to have for the release, as it easily fixes / papers over a rather
> > > > annoying / stupid (from the user's point of view) bug:
> >
> > > I pushed this to master and to the stable 3-3 branch, thanks for
> > > this.
> >
> > FYI, the OpenOffice.org side fixed this in a way that seems more
> > robust to eventual future changes; you might want to push that way
> > into at least master (IMHO maybe not stable 3-3 branch, probably not
> > 3-3-0).
> >
> > OTOH, if that's the robust way, why is it not the idiom to get the
> > value *everywhere*? I mean, why not replace *all* the
> >
> >   xProp->setPropertyValue(FOO,  uno::makeAny(static_cast<BAR*>(BAZ)->QUX()));
> >
> > by
>
> It is "robust" in the sense that SvxLRSpaceItem::QueryValue already
> performs cast to sal_Int32 if MID_L_MARGIN of MID_R_MARGIN member is
> requested. QueryValue is the generic way to get stuff from "items". The
> accessor functions are there for convenience.
>
> >   static_cast<const BAR*>(BAZ)->QueryValue(aValue,QUUX);
>
> Of course, the static_cast is superfluous there...
>
> D.
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr