Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Thanks!

I didn't see all four parts yet, but based on 2/4 and 3/4, you also do a lot of whitespace changes 
on lines without any comments. Please don't. That makes it harder to review the patch and makes it 
much larger than necessary.

Also, comments that are just boilerplate without any meaningful contents should be deleted, they 
don't need to be translated. I mean comments like:

/************************************************************************
 |*    LinkManager::Remove()
 |*
-|*    Beschreibung
+|*    Description
 *************************************************************************/

If you could redo your patches without the whitespace changes (and perhaps doing removal of empty 
boilerplate comments), and resend to the list, I would be glad, thanks!

--tml



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.