Re: [Libreoffice] [PATCH] [PUSHED] Cppcheck cleaning on oox

David Tardon <dtardon -AT- redhat.com>

Mon, 17 Jan 2011 09:21:09 +0100

On Sun, Jan 16, 2011 at 10:00:47PM +0100, Julien Nabet wrote:

Hello,

Here is a patch for some cppcheck cleaning on oox

Pushed, thanks!


In the file :
oox/source/drawingml/chart/objectformatter.cxx
in the line 930, there is this function
void EffectFormatter::convertFormatting( PropertySet& /*rPropSet*/,
const ModelRef< Shape >& /*rxShapeProp*/, sal_Int32 /*nSeriesIdx*/ )
const
{
}
the declaration of this function is line 662 :
    /** Converts effect formatting to the passed property set. */
    void                convertFormatting(
                            PropertySet& rPropSet,
                            const ModelRef< Shape >& rxShapeProp,
                            sal_Int32 nSeriesIdx ) const;

Does this function do something or should it be implemented (or just
simply remove it) ?

It is called at several places, so it looks like it should be implemented. I removed the added const from it, as it might cause confusion. D.

Context

[Libreoffice] [PATCH] Cppcheck cleaning on oox · Julien Nabet

Re: [Libreoffice] [PATCH] [PUSHED] Cppcheck cleaning on oox · David Tardon

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.