Re: [Libreoffice] [PATCH][PUSHED] unopkg crasher on SLED11-SP1 (bnc#655912)

Michael Meeks píše v Pá 14. 01. 2011 v 09:23 +0000:
> Hi Petr,
>
> On Thu, 2011-01-13 at 21:25 +0100, Petr Mladek wrote:
> > could you please review the attached patch for libreoffice-3-3 branch? 
>
>       Looks good to me; the method takes OUStrings, so there is no odd type
> co-ercion (that I can see) going on.

thanks for review; I have got approval also from Noel and Tor, so pushed
even to the libreoffice-3-3-0 branch.

> > It looks like a compiler bug. I see it only on SLED11 with one
> > particular gcc version. So, the solution is a kind of workaround but
> > it should be fine in general. See the patch for more details.
>
>       Personally, I don't believe we need such a huge block comment on this
> (in master at least):
>
>       // add temporaries to workaround gcc-4.3.4 specific bug

Fair enough ;-) I have simplified the comment to

// pass the two values via variables to workaround gcc-4.3.4 specific
bug (bnc#655912)

>       would be fine for me - and (after long experience) I trust your
> analysis of tangled compiler breakage :-) you have run the 'working' ie.
> non gcc-4.3.4 version through valgrind to ensure that the bug isn't
> there but hidden for some other reason ?

Yup, valgrind havn't seen any problems on openSUSE-11.3.

Best Regards,
Petr