Re: [Libreoffice] [REVIEW] needed for localize-ooo fix

On Fri, Jan 14, 2011 at 7:17 AM, Thorsten Behrens
<thb@documentfoundation.org> wrote:
> Hi,
>
> the extra localizations from LibO are not applied properly at least
> on Mac (not yet clear whether the .deb issue has the same root cause
> - https://bugs.freedesktop.org//show_bug.cgi?id=33105).
>
> Reason is a non-working localize-ooo, the first patch ensures bash
> is used (and portably found). I need triple approval for this, needs
> to go into 3-3-0
>
> The second patch avoids a somewhat fragile cut call - that one is
> not strictly necessary for 3-3-0, but I'd love to have it in 3-3

I'm ok with the 1st one.

the second one (awk) is missing a sigle-quote I think
     # merge the localization
-    if test `wc -l "$sdf_file_filtered" | cut -d " " -f 1` -eq 0 ; then
+    if test `wc -l "$sdf_file_filtered" | awk '{print $1}` -eq 0 ; then
        echo "Warning: Ignoring empty extra localization $(basename $sdf_file)..."
should be

     # merge the localization
-    if test `wc -l "$sdf_file_filtered" | cut -d " " -f 1` -eq 0 ; then
+    if test `wc -l "$sdf_file_filtered" | awk '{print $1}'` -eq 0 ; then
        echo "Warning: Ignoring empty extra localization $(basename $sdf_file)..."

Norbert
> Cheers,
>
> -- Thorsten
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice