Hmm, the first hunk adds a "delete pFmt" fix. I believe that's a false
positive from cppcheck, the pFmt comes from MakeSectionFmt and the
returned pFmt is placed on pSectionFmtTbl before being returned and
pSectionFmtTbl owns it and will release it later on.
So I remove that hunk.
The itemset from GetCollItemSet might indeed leak under some
circumstances, but in others it doesn't, so it doesn't looks safe to
unconditionally delete pCollSet; in the last hunk either though it does
look dodgy.
The other changes to use prefix variants of the ++ and reduce the scope
of some variables looks good, so pushed those bits. Thanks for this.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.