Re: [Libreoffice] [PATCH] some changes for better performance, writer.

On 10/01/2006 20:09, Kayo Hamid wrote:
> Please, someone can review this? Thkz.
>
> revol_
I forgot to change the headers, sorry. This patch covers the two patchs 
that I sent early.

> 
http://lists.freedesktop.org/archives/libreoffice/2011-January/005570.html
> 
http://lists.freedesktop.org/archives/libreoffice/2011-January/005576.html

revol_

diff --git a/sw/source/core/access/acccontext.hxx b/sw/source/core/access/acccontext.hxx
index 43612eb..5b2a49c 100644
--- a/sw/source/core/access/acccontext.hxx
+++ b/sw/source/core/access/acccontext.hxx
@@ -185,7 +185,7 @@ protected:
     void FireVisibleDataEvent();
 
     // broadcast state change event
-    void FireStateChangedEvent( sal_Int16 nState, sal_Bool bNewState );
+    void FireStateChangedEvent( sal_Int16 nState, const sal_Bool bNewState );
 
     // Set states for getAccessibleStateSet.
     // This base class sets DEFUNC(0/1), EDITABLE(0/1), ENABLED(1),
@@ -227,7 +227,7 @@ public:
 
     ///        Return the specified child or NULL if index is invalid.
     virtual ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible> 
SAL_CALL
-        getAccessibleChild (sal_Int32 nIndex)
+        getAccessibleChild (const sal_Int32 nIndex)
         throw (::com::sun::star::uno::RuntimeException,
                 ::com::sun::star::lang::IndexOutOfBoundsException);
 
@@ -346,7 +346,7 @@ public:
     virtual void Dispose( sal_Bool bRecursive = sal_False );
 
     // The child object is not visible an longer and should be destroyed
-    virtual void DisposeChild( const sw::access::SwAccessibleChild& rFrmOrObj, sal_Bool bRecursive 
);
+    virtual void DisposeChild( const sw::access::SwAccessibleChild& rFrmOrObj, const sal_Bool 
bRecursive );
 
     // The object has been moved by the layout
     virtual void InvalidatePosOrSize( const SwRect& rFrm );
@@ -370,7 +370,7 @@ public:
     // <--
 
     // the XAccessibleRelationSet may have changed
-    void InvalidateRelation( sal_uInt16 nType );
+    void InvalidateRelation( const sal_uInt16 nType );
 
     /** text selection has changed
 
@@ -411,7 +411,7 @@ public:
 
     virtual sal_Bool HasCursor();      // required by map to remember that object
 
-    sal_Bool Select( SwPaM *pPaM, SdrObject *pObj, sal_Bool bAdd );
+    sal_Bool Select( const SwPaM *pPaM, const SdrObject *pObj, const sal_Bool bAdd );
     inline sal_Bool Select( SwPaM& rPaM )
     {
         return Select( &rPaM, 0, sal_False );
@@ -421,7 +421,7 @@ public:
         return Select( 0, pObj, bAdd );
     }
 
-    static ::rtl::OUString GetResource( sal_uInt16 nResId,
+    static ::rtl::OUString GetResource( const sal_uInt16 nResId,
                                         const ::rtl::OUString *pArg1 = 0,
                                         const ::rtl::OUString *pArg2 = 0 );
 
diff --git a/sw/source/core/access/accdoc.hxx b/sw/source/core/access/accdoc.hxx
index 05f0613..5be2b04 100644
--- a/sw/source/core/access/accdoc.hxx
+++ b/sw/source/core/access/accdoc.hxx
@@ -56,7 +56,7 @@ public:
 
     void SetVisArea();
 
-    virtual void AddChild( Window *pWin, sal_Bool bFireEvent = sal_True );
+    virtual void AddChild( Window *pWin, const sal_Bool bFireEvent = sal_True );
     virtual void RemoveChild( Window *pWin );
 
     //=====  XAccessibleContext  ==============================================
@@ -67,7 +67,7 @@ public:
 
     ///        Return the specified child or NULL if index is invalid.
     virtual ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible> 
SAL_CALL
-        getAccessibleChild (sal_Int32 nIndex)
+        getAccessibleChild (const sal_Int32 nIndex)
         throw (::com::sun::star::uno::RuntimeException,
                 ::com::sun::star::lang::IndexOutOfBoundsException);
 
@@ -182,7 +182,7 @@ public:
                 ::com::sun::star::uno::RuntimeException );
 
     virtual sal_Bool SAL_CALL isAccessibleChildSelected(
-        sal_Int32 nChildIndex )
+        const sal_Int32 nChildIndex )
         throw ( ::com::sun::star::lang::IndexOutOfBoundsException,
                 ::com::sun::star::uno::RuntimeException );
     virtual void SAL_CALL clearAccessibleSelection(  )
@@ -192,20 +192,20 @@ public:
     virtual sal_Int32 SAL_CALL getSelectedAccessibleChildCount(  )
         throw ( ::com::sun::star::uno::RuntimeException );
     virtual ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible > 
SAL_CALL getSelectedAccessibleChild(
-        sal_Int32 nSelectedChildIndex )
+        const sal_Int32 nSelectedChildIndex )
         throw ( ::com::sun::star::lang::IndexOutOfBoundsException,
                 ::com::sun::star::uno::RuntimeException);
 
     // --> OD 2004-11-16 #111714# - index has to be treated as global child index.
     virtual void SAL_CALL deselectAccessibleChild(
-        sal_Int32 nChildIndex )
+        const sal_Int32 nChildIndex )
         throw ( ::com::sun::star::lang::IndexOutOfBoundsException,
                 ::com::sun::star::uno::RuntimeException );
 
     //====== thread safe C++ interface ========================================
 
     // The object is not visible an longer and should be destroyed
-    virtual void Dispose( sal_Bool bRecursive = sal_False );
+    virtual void Dispose( const sal_Bool bRecursive = sal_False );
 };
 
 #endif