Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello,

I used xargs instead of -exec to reduce chmod spawning.
Hope there's no mistake in it.

Julien

PS : the first sending seemed not having worked.
commit d5a814812d592d36db85575bb80ab73817cd3e78
Author: Julien Nabet <serval2412@yahoo.fr>
Date:   Sat Jan 8 02:01:25 2011 +0100

    Reducing spawning of chmod with xargs instead of exec

diff --git a/solenv/bin/modules/installer/epmfile.pm b/solenv/bin/modules/installer/epmfile.pm
index 9e9ef1e..84efc6e 100644
--- a/solenv/bin/modules/installer/epmfile.pm
+++ b/solenv/bin/modules/installer/epmfile.pm
@@ -2408,7 +2408,7 @@ sub create_packages_without_epm
                 # Setting unix rights to "775" for all created directories inside the package,
                 # that is saved in temp directory              
 
-                $systemcall = "cd $packagestempdir; find $packagename -type d -exec chmod 775 \{\} 
\\\;";
+                $systemcall = "cd $packagestempdir; find $packagename -type d | xargs -i chmod 775 
\{\} \;";
                 installer::logger::print_message( "... $systemcall ...\n" );
 
                 $returnvalue = system($systemcall);
@@ -2471,7 +2471,7 @@ sub create_packages_without_epm
 
         # Setting unix rights to "775" for all created directories inside the package
         
-        $systemcall = "cd $destinationdir; find $packagename -type d -exec chmod 775 \{\} \\\;";
+        $systemcall = "cd $destinationdir; find $packagename -type d | xargs -i chmod 775 \{\} \;";
         installer::logger::print_message( "... $systemcall ...\n" );
 
         $returnvalue = system($systemcall);

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.