On Fri, 2011-01-07 at 11:07 +0000, Caolán McNamara wrote:
On Thu, 2011-01-06 at 20:36 +0100, Guillaume Poussel wrote:
Hi everybody,
A new patch which correct cppcheck warnings in base/.
Looks good, pushed. Thanks for this.
Oops, I see now that cppcheck isn't run with sufficient -I flags to find
includes, so it wasn't able to see that pDesc is actually used by some
MACRO stuff which was hidden from it, so these were cppcheck false
positives, as are probably the "missing ctor" warnings.
I fixed up the pDesc ones again in a way to hide them from cppcheck
again.
We probably should figure out how to sufficient -I flags to cppcheck to
get it to find the includes. This is probably a bit tricky unless we add
a make cppcheck or something to libreoffice itself or something.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.