Re: [Libreoffice] sign off for cherry-pick fix for crash on exit after using search in calc

On Thu, 2011-01-06 at 17:23 +0000, Caolán McNamara wrote:
> i.e. see bug: https://bugzilla.redhat.com/show_bug.cgi?id=666088 for
> details. 
>
> Attached is the proposed fix. Don't let the fancy-pants rtl::Static put
> you off, its just making the maCache from a global to a static local.
>
> Globals/static locals have their dtors called in reverse order of the
> completion of their ctors. Leaving the complex global at its current
> scope means it gets shutdown too late on final dlclose of libunotools,
> at a point after which all the runtime structure that it needs has been
> shutdown. Changing it to a local static ensures it gets dtored before
> that.

I can sign off on this.  I believe this code was originally my patch and
Eike changed it a bit.  I remember this one.

Nothing weird about this change, so looks good to me. :-)

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>