Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi Kohei,

On Mon, 03 Jan 2011 22:14:17 -0500, Kohei Yoshida <kyoshida@novell.com> wrote:
The patch looks good.  I just pushed it to master.
Thanks for your review!


The only changes I made are just fixing some coding styles and updating
the cmdline help to promote --foo style options.
Then is it also desirable to update the shell trampolines to use the long
prefix, as attached?

Cheers,
-- Takeshi Abe
From 3955f7391955fd9b52fe5d4887e260e3a64df5eb Mon Sep 17 00:00:00 2001
From: Takeshi Abe <tabe@fixedpoint.jp>
Date: Tue, 4 Jan 2011 23:45:49 +0900
Subject: [PATCH] prefer the long prefix '--'

---
 desktop/scripts/sbase.sh    |    2 +-
 desktop/scripts/scalc.sh    |    2 +-
 desktop/scripts/sdraw.sh    |    2 +-
 desktop/scripts/simpress.sh |    2 +-
 desktop/scripts/smaster.sh  |    2 +-
 desktop/scripts/smath.sh    |    2 +-
 desktop/scripts/sweb.sh     |    2 +-
 desktop/scripts/swriter.sh  |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/desktop/scripts/sbase.sh b/desktop/scripts/sbase.sh
index 932a535..e3a8ed0 100644
--- a/desktop/scripts/sbase.sh
+++ b/desktop/scripts/sbase.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -base "$@"
+exec "$cmd" --base "$@"
diff --git a/desktop/scripts/scalc.sh b/desktop/scripts/scalc.sh
index b1c3eeb..c9c3cde 100644
--- a/desktop/scripts/scalc.sh
+++ b/desktop/scripts/scalc.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -calc "$@"
+exec "$cmd" --calc "$@"
diff --git a/desktop/scripts/sdraw.sh b/desktop/scripts/sdraw.sh
index fe0338a..4131a25 100644
--- a/desktop/scripts/sdraw.sh
+++ b/desktop/scripts/sdraw.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -draw "$@"
+exec "$cmd" --draw "$@"
diff --git a/desktop/scripts/simpress.sh b/desktop/scripts/simpress.sh
index 20cae50..d78ea14 100644
--- a/desktop/scripts/simpress.sh
+++ b/desktop/scripts/simpress.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -impress "$@"
+exec "$cmd" --impress "$@"
diff --git a/desktop/scripts/smaster.sh b/desktop/scripts/smaster.sh
index affd55b..ed9b09d 100644
--- a/desktop/scripts/smaster.sh
+++ b/desktop/scripts/smaster.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -global "$@"
+exec "$cmd" --global "$@"
diff --git a/desktop/scripts/smath.sh b/desktop/scripts/smath.sh
index ae4e367..454fa13 100644
--- a/desktop/scripts/smath.sh
+++ b/desktop/scripts/smath.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -math "$@"
+exec "$cmd" --math "$@"
diff --git a/desktop/scripts/sweb.sh b/desktop/scripts/sweb.sh
index 6d814e2..a365392 100644
--- a/desktop/scripts/sweb.sh
+++ b/desktop/scripts/sweb.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -web "$@"
+exec "$cmd" --web "$@"
diff --git a/desktop/scripts/swriter.sh b/desktop/scripts/swriter.sh
index 34ca9fe..3fa48c0 100644
--- a/desktop/scripts/swriter.sh
+++ b/desktop/scripts/swriter.sh
@@ -1,4 +1,4 @@
 #!/bin/sh
 
 cmd=`dirname "$0"`/soffice
-exec "$cmd" -writer "$@"
+exec "$cmd" --writer "$@"
-- 
1.7.2.3


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.