Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Mon, 03 Jan 2011 01:52:01 -0800, Cedric Bosdonnat <cbosdonnat@novell.com> wrote:
The thing is that Window::Invalidate() gets called if I move or if I type
inside a table cell, which almost any key triggers, which is wrong.
bUpdatedTable gets set to True inside SwCallLink::~SwCallLink() after
some tests. Another option would be to correct those tests, but that
would be far beyond my knowledge.

The problem I tried to fix was that the whole row wasn't redrawn in some
cases... I can't remember those for sure now but it was something like
that:

Make sure to have tables like this:
+-----------------+-----------------------+
|+---------------+|                       |
||               ||                       |
|+---------------+|                       |
|                 |                       |
+-----------------+-----------------------+

Place your cursor in the right cell and go to the left: the cursor
should go in the blank paragraph after the nested cell and show it. In
that kind of cases some part of the border of the right cell wasn't
redrawn IIRC.

Did you test with a case similar to the one above?

Well, I did try several different combinations including different column
sizes and nesting levels. The case you point out was also tested and
I just retested it now. It works. I would say it performs better.

In the patch included I also remove all uses and declaration of
bUpdatedTable because it was only used on the removed if().

--
Octavio.

Twitter: @alvarezp2000 -- Identi.ca: @alvarezp

Attachment: 0001-SwCallLink-Removed-unnecesarry-Invalidate-call.patch
Description: Binary data


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.