Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


Hi everybody,


I use LibreOffice almost every day and I'm interested in Open Source softwares, so I would like to contribute.


I have grabbed the code and compile it. Then, i had a look on the wiki and found an easy task : "Remove bogus macro that expand to empty string" <http://wiki.documentfoundation.org/index.php?title=Development/Easy_Hacks&setlang=en#Remove_bogus_macros_that_expand_to_empty_string>.
I've attached a text file which contains my diff on 4 files I have edited.

Could someone please have a look and tell me if i'm on the right way ?

Cheers,
Guillaume.

P.S. : I'm a french student (in computer science :) ), so I'm sorry if my english is not perfect :)

diff --git binfilter/inc/bf_sfx2/docfac.hxx binfilter/inc/bf_sfx2/docfac.hxx
index 085d11c..646b87d 100644
--- binfilter/inc/bf_sfx2/docfac.hxx
+++ binfilter/inc/bf_sfx2/docfac.hxx
@@ -635,7 +635,7 @@ extern "C"
             Factory().RegisterInitFactory( &InitFactory    );                    \
     }                                                                                              
                                              \
                                                                               \
-    SfxObjectShell*    __EXPORT Class::CreateObject(SfxObjectCreateMode eMode)   \
+    SfxObjectShell* Class::CreateObject(SfxObjectCreateMode eMode)       \
     {                                                                                              
                                              \
         SfxCreateExtern_TYPE fCreate = (SfxCreateExtern_TYPE)                  \
             GetFunc##LibName( "CreateObj" #Class "Dll");            \
diff --git svtools/source/contnr/svlbox.cxx svtools/source/contnr/svlbox.cxx
index 6eb2860..989a5b7 100644
--- svtools/source/contnr/svlbox.cxx
+++ svtools/source/contnr/svlbox.cxx
@@ -1696,7 +1696,7 @@ sal_Int8 SvLBox::AcceptDrop( const AcceptDropEvent& rEvt )
         }
         else
         {
-            DBG_ASSERT( pDDSource, "SvLBox::QueryDrop(): SourceBox == 0 (__EXPORT?)" );
+            DBG_ASSERT( pDDSource, "SvLBox::QueryDrop(): SourceBox == 0" );
             if( !( pEntry && pDDSource->GetModel() == this->GetModel()
                     && DND_ACTION_MOVE == rEvt.mnAction
                     && ( pEntry->nEntryFlags & SV_ENTRYFLAG_DISABLE_DROP ) ))
diff --git tools/inc/tools/solar.h tools/inc/tools/solar.h
index 0ecaf58..8b72805 100644
--- tools/inc/tools/solar.h
+++ tools/inc/tools/solar.h
@@ -88,7 +88,6 @@ typedef sal_uInt32                    UINT32; /* typedef unsigned int    UINT32; 
previously "unsi
 #define DELETEZ( p )   ( delete p,p = 0 )
 
 #define __READONLY_DATA                const
-#define __EXPORT
 
 #ifdef WNT
 #if defined (_MSC_VER) && ( _MSC_VER < 1200 )
diff --git sfx2/inc/sfx2/childwin.hxx sfx2/inc/sfx2/childwin.hxx
index f3e058a..5de9fba 100644
--- sfx2/inc/sfx2/childwin.hxx
+++ sfx2/inc/sfx2/childwin.hxx
@@ -313,7 +313,7 @@ public:
                     SfxChildWindow *pWin = new Class(pParent, nId, pBindings, pInfo);\
                     return pWin; \
                 } \
-        sal_uInt16     __EXPORT Class::GetChildWindowId () \
+        sal_uInt16 Class::GetChildWindowId () \
                 { return MyID; } \
         void   Class::RegisterChildWindow (sal_Bool bVis, SfxModule *pMod, sal_uInt16 nFlags)   \
                 {      \

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.