Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for framework properties

Le 18/12/2010 13:47, Caolán McNamara a écrit :
> On Sat, 2010-12-18 at 02:41 +0100, Julien Nabet wrote:
>    
> > Hello,
> >
> > Here is a patch for properties.h of framework
> > framework compiles ok.
> >      
> Looks good, thanks for this. Pushed.
>
> C.
>
>
>    
Hello,

I made a global fgrep for searching the remaining createFromAscii we 
could remove.
I manually removed the cases where I thought createFromAscii must stay.

But I saw 2 cases in this searching where I don't know if we can replace 
createFromAscii :
- e.g. in components/forms/source/misc/services.cxx :    
aServices.getArray()[0] = rtl::OUString::createFromAscii( 
"com.sun.star.xforms." #name );
- e.g. in ure/sal/workben/measure_oustrings.cxx:    std::cout << 
"rtl::OUString::createFromAscii(\"XXXXXXXX\") " << nEndTime - nStartTime 
<< "ms" << std::endl;

And about macros that use createFromAscii, should we remove them ?

Julien.

calc/scaddins/source/analysis/analysisdefs.hxx:#define STRFROMASCII(s)          
STRING::createFromAscii( s )
calc/chart2/source/tools/MediaDescriptorHelper.cxx:if(rProp.Name.equals(::rtl::OUString::createFromAscii(#MediaName)))
  \
components/forms/source/misc/services.cxx:        
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.form.") ) + 
::rtl::OUString::createFromAscii(#classImplName), \
components/forms/source/misc/services.cxx:    aServices.getArray()[0] = 
rtl::OUString::createFromAscii( "com.sun.star.xforms." #name ); \
components/forms/source/inc/FormComponent.hxx:        { return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.comp.forms.") ) + 
::rtl::OUString::createFromAscii(#ImplName); }
filters/binfilter/bf_forms/source/misc/forms_services.cxx:        ::rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( "com.sun.star.form." )) + 
::rtl::OUString::createFromAscii(#classImplName), \
filters/binfilter/bf_forms/source/component/FormComponent.hxx:        { return ::rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( "com.sun.star.comp.forms." )) + 
::rtl::OUString::createFromAscii(#ImplName); }
libs-core/scripting/source/inc/util/util.hxx:#define OUSTR(x) ::rtl::OUString( 
::rtl::OUString::createFromAscii(x) )
libs-core/linguistic/inc/misc.hxx:#define A2OU(x) ::rtl::OUString::createFromAscii( x )
libs-core/linguistic/workben/sprophelp.cxx:#define A2OU(x)      ::rtl::OUString::createFromAscii( x 
)
libs-core/linguistic/workben/sspellimp.hxx:#define A2OU(x)      ::rtl::OUString::createFromAscii( x 
)
libs-core/linguistic/source/defs.hxx:#define A2OU(x)    ::rtl::OUString::createFromAscii( x )
libs-gui/i18npool/source/transliteration/transliteration_body.cxx:#define A2OU(x) 
OUString::createFromAscii(x)
libs-gui/i18npool/source/collator/collator_unicode.cxx:        if (!collator && 
OUString::createFromAscii(LOCAL_RULE_LANGS).indexOf(rLocale.Language) >= 0) {
libs-gui/svl/source/config/cjkoptions.cxx:#define C2U(cChar) OUString::createFromAscii(cChar)
libs-gui/svl/source/config/srchcfg.cxx:#define C2U(cChar) OUString::createFromAscii(cChar)
libs-gui/svl/source/config/asiancfg.cxx:#define C2U(cChar) OUString::createFromAscii(cChar)
libs-gui/toolkit/inc/toolkit/helper/macros.hxx:    ::rtl::OUString SAL_CALL getImplementationName(  
) throw(::com::sun::star::uno::RuntimeException) { return ::rtl::OUString::createFromAscii( 
"stardiv.Toolkit." #ImplName ); } \
libs-gui/toolkit/inc/toolkit/helper/macros.hxx:    ::rtl::OUString SAL_CALL getImplementationName(  
) throw(::com::sun::star::uno::RuntimeException) { return ::rtl::OUString::createFromAscii( 
"stardiv.Toolkit." #ImplName ); } \
libs-gui/toolkit/source/controls/unocontrols.cxx:    ::rtl::OUString SAL_CALL 
ImplName::getImplementationName(  ) throw(::com::sun::star::uno::RuntimeException) { return 
::rtl::OUString::createFromAscii( "stardiv.Toolkit." #ImplName ); } \
libs-gui/unotools/source/config/regoptions.cxx:        static const ::rtl::OUString sName = 
::rtl::OUString::createFromAscii( #name );  \
libs-gui/unotools/source/config/configitem.cxx:#define C2U(cChar) OUString::createFromAscii(cChar)
libs-gui/unotools/source/config/misccfg.cxx:#define C2U(cChar) OUString::createFromAscii(cChar)
libs-gui/unotools/source/config/fltrcfg.cxx:#define C2U(cChar) OUString::createFromAscii(cChar)
libs-gui/unotools/source/config/lingucfg.cxx:#define A2OU(x)        
::rtl::OUString::createFromAscii( x )
libs-gui/unotools/source/config/javaoptions.cxx:#define C2U(cChar) OUString::createFromAscii(cChar)
libs-gui/dtrans/source/win32/ftransl/ftransl.cxx:#define OUSTR( str )                     
OUString::createFromAscii( #str )
libs-gui/dtrans/source/win32/ftransl/ftransl.cxx:#define OUSTR_( str )             
OUString::createFromAscii( str )
ure/sal/workben/measure_oustrings.cxx:    std::cout << "rtl::OUString::createFromAscii(\"X\") " << 
nEndTime - nStartTime << "ms" << std::endl;
ure/sal/workben/measure_oustrings.cxx:    std::cout << 
"rtl::OUString::createFromAscii(\"XXXXXXXX\") " << nEndTime - nStartTime << "ms" << std::endl;
writer/sw/inc/unomid.h:#define C2U(cChar) rtl::OUString::createFromAscii( cChar )