Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


On Mon, 2010-12-13 at 21:41 +0100, Joachim Trémouroux wrote:
Hi,

Here are some various cppcheck cleanup in vcl.

Incidentally, while checking for one ccpcheck warning I have found a
duplicate definition and implementation of two classes:
PspSalInfoPrinter and PspSalPrinter are defined both in
vcl/unx/inc/salprn.h and vcl/unx/headless/svpprn.hxx
The implementation looks the same in vcl/unx/headless/svpprn.cxx and
vcl/unx/source/gdi/salprnpsp.cxx

Yes, those should be merged if possible. Do you want to do that. I
suggest Taking the "vcl/unx/inc/salprn.h" one as the "proper" one and
remove the "vcl/unx/headless/svpprn.hxx" one in favour of it.

The reason this happened, IIRC, was basically because the "headless" vcl
plug was a StarOffice only feature for a while. So while some of the the
hooks went into the shared OpenOffice.org core, the headless part itself
was kept out of OpenOffice.org, which necessitated the duplication of
some classes. 

When the situation got finally rectified the duplicate remained.

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.